Snapshot interpolation #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with DMD. Pivoting the DMD changes to derived class SnapshotDMD in future commits. Turned off "window overlap" in parametric_dw_csv.
construct SnapshotDMD as a separat PR.
ptranq
requested review from
ckendrick,
dylan-copeland,
dreamer2368,
chldkdtn,
andersonw1 and
siuwuncheung
|
@dylan-copeland I have implemented a googletest unit test for the snapshot interpolation, and addressed all of your other comments. |
dylan-copeland
approved these changes
Jun 4, 2024
ckendrick
requested changes
Jun 5, 2024
statements to guarantee strictly increasing input / output ts, that there are >2 input ts, and that there are >1 output ts.
ckendrick
approved these changes
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the SnapshotInterpolator class as well as its unit test. This implements PCHIP interpolation.